-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): feature for server side container url support ga4 #1814
Conversation
WalkthroughWalkthroughThe recent updates to the GA4 integration enhance its configurability by introducing a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GA4
participant Analytics
User->>GA4: Initialize with serverContainerUrl
GA4->>GA4: Check if serverContainerUrl is defined
alt Defined
GA4->>Analytics: Send tracking data with server_container_url
else Not Defined
GA4->>Analytics: Send tracking data without server_container_url
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/analytics-js-integrations/src/integrations/GA4/browser.js (5 hunks)
Additional comments not posted (3)
packages/analytics-js-integrations/src/integrations/GA4/browser.js (3)
47-47
: New propertyserverContainerUrl
added to the constructor.The
serverContainerUrl
property allows specifying a server container URL for Google Analytics tracking. Ensure this property is correctly utilized in the class methods.
66-68
: IncludeserverContainerUrl
ingtagParameterObject
if defined.The
serverContainerUrl
is now included in thegtagParameterObject
when it is defined and not null. This enhances the configurability of the GA4 integration.
66-68
: LGTM! The inclusion ofserverContainerUrl
is correct.The changes to include
serverContainerUrl
in thegtagParameterObject
are correct and improve the flexibility of the configuration.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1814 +/- ##
==========================================
+ Coverage 56.54% 56.67% +0.13%
==========================================
Files 473 473
Lines 16114 16111 -3
Branches 3229 3216 -13
==========================================
+ Hits 9111 9131 +20
- Misses 5726 5764 +38
+ Partials 1277 1216 -61 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
size-limit report 📦
|
PR Description
Adding support for server side container support for Ga4
Linear task (optional)
INT-2454
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
New Features
serverContainerUrl
property, improving tracking flexibility.Bug Fixes
serverContainerUrl
to ensure proper configuration.Style